-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DDW-316] Extend incident and alert newsfeed type #2099
Merged
nikolaglumac
merged 6 commits into
develop
from
chore/ddw-316-extend-incident-and-alert-newsfeed-type
Jul 27, 2020
Merged
[DDW-316] Extend incident and alert newsfeed type #2099
nikolaglumac
merged 6 commits into
develop
from
chore/ddw-316-extend-incident-and-alert-newsfeed-type
Jul 27, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-rukin
approved these changes
Jul 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
tomislavhoracek
requested review from
nikolaglumac,
thedanheller and
darko-mijic
July 27, 2020 14:56
nikolaglumac
approved these changes
Jul 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing @tomothespian 🚀
darko-mijic
approved these changes
Jul 27, 2020
iohk-bors
bot
deleted the
chore/ddw-316-extend-incident-and-alert-newsfeed-type
branch
July 27, 2020 16:00
nikolaglumac
added
release-2.0.0-RC1
Daedalus Mainnet
and removed
⏳release-vNext
labels
Aug 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces themed incidents regarding to newly introduced
color
parameter from the newsfeed item. Also, alerts are updated withrepeatOnStartup
parameter. IfrepeatOnStartup
exists in alert newsfeed item, alert will be shown on each Daedalus startup.Incident can have
red
,theme-default
orgrey
color value and is not mandatory.Alert can have
repeatOnStartup
boolean value and it is also not mandatory.Todos
Screenshots
Grey:
Light Blue:
Cardano:
Dark Blue:
Dark Cardano:
Flight Candidate:
Incentivized Testnet:
Shelley testnet:
White:
Yellow:
Testing Checklist
Review Checklist
Basics
feature
/bug
/chore
,release-x.x.x
)yarn test
)yarn dev
)yarn package
/ CI builds)yarn flow:test
)yarn lint
)yarn prettier:check
)yarn manage:translations
produces no changes)yarn storybook
)yarn.lock
file is updatedCode Quality
Testing
After Review
done
column on the YouTrack board