[DDW-296] Daedalus review fixes

[DeeJayElly]

This PR fixes all UI specific issues found during the last review of Daedalus.
Lists of fixed issues:

1. https://docs.google.com/document/d/1iFkI644fXMWgvFIGVFwLrvLzrvjnUyGO0FlmA2pPPPQ/edit
2. https://docs.google.com/document/d/1Wj6_TNos1jglVfKK2EV23zZ9PopLeKRuzpucE58PsNE/edit

---

Testing Checklist

• Slack QA thread

---

Review Checklist

Basics

• PR has been assigned and has appropriate labels (feature/bug/chore, release-x.x.x)
• PR is updated to the most recent version of the target branch (and there are no conflicts)
• PR has a good description that summarizes all changes
• PR has default-sized Daedalus window screenshots or animated GIFs of important UI changes:
  • In English
  • In Japanese
• CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
• Automated tests: All acceptance and unit tests are passing (yarn test)
• Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn dev)
• Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn package / CI builds)
• There are no flow errors or warnings (yarn flow:test)
• There are no lint errors or warnings (yarn lint)
• There are no prettier errors or warnings (yarn prettier:check)
• There are no missing translations (running yarn manage:translations produces no changes)
• Text changes are proofread and approved (Jane Wild / Amy Reeve)
• Japanese text changes are proofread and approved (Junko Oda)
• UI changes look good in all themes (Alexander Rukin)
• Storybook works and no stories are broken (yarn storybook)
• In case of dependency changes yarn.lock file is updated

Code Quality

• Important parts of the code are properly commented and documented
• Code is properly typed with flow
• React components are split-up enough to avoid unnecessary re-renderings
• Any code that only works in main process is neatly separated from components

Testing

• New feature/change is covered by acceptance tests
• New feature/change is manually tested and approved by QA team
• All existing acceptance tests are still up-to-date
• New feature/change is covered by Daedalus Testing scenario
• All existing Daedalus Testing scenarios are still up-to-date

After Review

• Merge the PR
• Delete the source branch
• Move the ticket to done column on the YouTrack board
• Update Slack QA thread by marking it with a green checkmark

[gabriela-ponce]

@DeeJayElly The last fixes look great. There is some new issue with the dropdowns on delegation slider and dialog, not sure if this is related to this PR.

[nikolaglumac]

@DeeJayElly The last fixes look great. There is some new issue with the dropdowns on delegation slider and dialog, not sure if this is related to this PR.

@gnpf @DeeJayElly both of these issues are fixed with 4ecd1a1

[nikolaglumac]

Great work @DeeJayElly 🎉

[gabriela-ponce]

@DeeJayElly @nikolaglumac The spinner on "Rewards" is misaligned (this is not happening on develop and last production build)

[alexander-rukin]

can we fit it in one line 😓 ?

[alexander-rukin]

Was it always like this? I mean the 30px padding belongs to scrollable area, not button (it aclually could be a a split 20 + 10) -> now it looks like cropped

[DeeJayElly]

Was it always like this? I mean the 30px padding belongs to scrollable area, not button (it aclually could be a a split 20 + 10) -> now it looks like cropped

Fixed. I split them in 2 parts 20px+10px;

[DeeJayElly]

can we fit it in one line 😓 ?

Fixed

[DeeJayElly]

@DeeJayElly @nikolaglumac The spinner on "Rewards" is misaligned (this is not happening on develop and last production build)

Fixed

[DeeJayElly]

@nikolaglumac @a-rukin @gnpf All the requested changes have been implemented, this PR is ready to be merged.

[alexander-rukin]

Fixes look good to me)