-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DDW-369] Implement copy CSS variables #2196
[DDW-369] Implement copy CSS variables #2196
Conversation
@daniloprates I would like you to have a discussion about this one with @DominikGuzei 🙏 |
Let's do it :) |
@nikolaglumac Danilo and I discussed this task and both think it's useful 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @daniloprates 🎉
There are some flow and lint errors I hope you can fix 🙏
Also, can you please add CHANGELOG entry and update the Theming Readme: https://github.com/input-output-hk/daedalus/blob/develop/source/renderer/app/themes/README.md with info about your script? Also, it would be awesome if you can review existing content of that file...
Thanks!
@nikolaglumac done. I didn't change the rest of the README content because it's just linking to the YT tutorials. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@daniloprates thanks for fixing the issues!
Please fix these remaining 2 lint issues and then we are ready to merge this PR!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @daniloprates 💯
This PR introduces a tool that allows for developers to quickly copy properties from an element into another in all theme files.
Screenshots
Testing Checklist
Review Checklist
Basics
feature
/bug
/chore
,release-x.x.x
)yarn test
)yarn dev
)yarn package
/ CI builds)yarn flow:test
)yarn lint
)yarn prettier:check
)yarn manage:translations
produces no changes)yarn storybook
)yarn.lock
file is updatedCode Quality
Testing
After Review
done
column on the YouTrack board