Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDW-436] Fix leftovers not being displayed correctly #2231

Merged

Conversation

thedanheller
Copy link
Contributor

@thedanheller thedanheller commented Nov 3, 2020

This PR fixes leftovers not being displayed correctly.

Todos

  • Remove hardcoded leftovers value
  • Subtract leftovers from the total amount

Screenshots

The issues

  1. The leftovers value is shown, even though in the result the source wallet (TestB) is left with 0 ADA;
  2. The leftovers value is not subtracted from the total amount.

image
image

Issues fixed

  1. The leftovers value is not shown when not provided by the API:

image

  1. When leftovers value is present, it is subtracted from the total amount:

image


Testing Checklist

  • Slack QA thread
  • Make a normal transferring funds operation. The leftovers will probably not appear, as it is a very rare case.
  • On Storybook, change the leftovers slider. Then the value is zero, the leftovers should not appear on the screen. Other values should alter the Total amount.

Review Checklist

Basics

  • PR has been assigned and has appropriate labels (feature/bug/chore, release-x.x.x)
  • PR is updated to the most recent version of the target branch (and there are no conflicts)
  • PR has a good description that summarizes all changes
  • PR has default-sized Daedalus window screenshots or animated GIFs of important UI changes:
    • In English
    • In Japanese
  • CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
  • Automated tests: All acceptance and unit tests are passing (yarn test)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn dev)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn package / CI builds)
  • There are no flow errors or warnings (yarn flow:test)
  • There are no lint errors or warnings (yarn lint)
  • There are no prettier errors or warnings (yarn prettier:check)
  • There are no missing translations (running yarn manage:translations produces no changes)
  • Text changes are proofread and approved (Jane Wild / Amy Reeve)
  • Japanese text changes are proofread and approved (Junko Oda)
  • UI changes look good in all themes (Alexander Rukin)
  • Storybook works and no stories are broken (yarn storybook)
  • In case of dependency changes yarn.lock file is updated

Code Quality

  • Important parts of the code are properly commented and documented
  • Code is properly typed with flow
  • React components are split-up enough to avoid unnecessary re-renderings
  • Any code that only works in main process is neatly separated from components

Testing

  • New feature/change is covered by acceptance tests
  • New feature/change is manually tested and approved by QA team
  • All existing acceptance tests are still up-to-date
  • New feature/change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review

  • Merge the PR
  • Delete the source branch
  • Move the ticket to done column on the YouTrack board
  • Update Slack QA thread by marking it with a green checkmark

@thedanheller thedanheller self-assigned this Nov 3, 2020
@thedanheller thedanheller changed the base branch from develop to release/2.4.1-FC1 November 3, 2020 19:26
@thedanheller thedanheller changed the base branch from release/2.4.1-FC1 to develop November 3, 2020 19:31
@nikolaglumac nikolaglumac self-requested a review November 4, 2020 09:01
Copy link
Contributor

@nikolaglumac nikolaglumac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix @daniloprates 💯

@nikolaglumac nikolaglumac merged commit 235a0b8 into develop Nov 4, 2020
@iohk-bors iohk-bors bot deleted the fix/ddw-436-fix-leftovers-not-being-displayed-correctly branch November 4, 2020 09:08
@nikolaglumac nikolaglumac added release-2.4.1 Daedalus Mainnet and removed ⏳release-vNext labels Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug release-2.4.1 Daedalus Mainnet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants