Fix empty disk space calculation for some Linux distributions #2258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Linux installer runs Daedalus inside a chroot, which lives in a temporary directory. Some - perhaps most - Linux distros have the temporary directory as a tmpfs (RAM drive). So when Daedalus checks the free space in /, it is reporting the amount of free space on the tmpfs - typically only a few GB. This change makes Daedalus check the free space for the state directory. In any case, this is a good thing to do, because the state directory (in the user's home directory) may be on a different partition to /.
|
@rvl @nikolaglumac I compared this with an old build on all platforms and the information about the disk space seems to be as accurate with this fix. Here are the results: Another build: Build 15394: However, I couldn't reproduce this issue initially, even with a partitioned disk. Should we ask @KtorZ to review this too? |
|
I could reproduce on Linux Daedalus flight:
And it appears to be fixed on build 15394 testnet.
|
nikolaglumac
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Linux installer runs Daedalus inside a chroot, which lives in a temporary directory.
Some - perhaps most - Linux distros have the temporary directory as a tmpfs (RAM drive).
So when Daedalus checks the free space in /, it is reporting the amount of free space on the tmpfs - typically only a few GB.
This change makes Daedalus check the free space for the state directory.
In any case, this is a good thing to do, because the state directory (in the user's home directory) may be on a different partition to /.
Testing
I haven't done any testing on this.