[DDW-536] Service agreement can be skipped by accessing to Settings #2304

topseniors · 2021-01-18T08:58:23Z

This PR disabled certain menu items when accepting terms of use.
Jira Ticket

Todos

Disable Settings, Wallet Settings, About Daedalus, and Daedalus Diagnostics menu items when accepting terms of use

Testing Checklist

Slack QA thread

App

Start daedalus and make sure the menu items mentioned above are disabled when accepting terms of use

Test Cases

Scenario 1 - Validate "Wallet settings" is disabled on the "Initial Settings" screen

Given Daedalus is executed for the first time after installation
And I am on the "Initial Settings" screen
When I click on "View" (Or "Daedalus" on macOS)
Then I can see the "Wallet settings" option is disabled
And I can't access by the keyboard shortcut

Scenario 2 - Validate "Settings" is disabled is disabled on "Initial Settings" screen

Given Daedalus is executed for the first time after installation
And I am on the "Initial Settings" screen
When I click on "View" (Or "Daedalus" on macOS)
Then I can see the "Settings" option is disabled
And I can't access by the keyboard shortcut

Scenario 3 - Validate "About" is disabled is disabled on "Initial Settings" screen

Given Daedalus is executed for the first time after installation
And I am on the "Initial Settings" screen
When I click on "Daedalus"
Then I can see the "About" option is disabled

Scenario 4 - Validate "Daedalus Diagnostics" is disabled is disabled on "Initial Settings" screen

Given Daedalus is executed for the first time after installation
And I am on the "Initial Settings" screen
When I click on "Help"
Then I can see the "Daedalus Diagnostics" option is disabled
And I can't access by the keyboard shortcut

Scenario 5 - Validate "Wallet settings" is disabled on "Service Agreement" screen

Given Daedalus is executed for the first time after installation
And I am on the "Service agreement" screen
When I click on "View" (Or "Daedalus" on macOS)
Then I can see the "Wallet settings" option is disabled
And I can't access by the keyboard shortcut

Scenario 6 - Validate "Settings" is disabled is disabled on "Service Agreement" screen

Given Daedalus is executed for the first time after installation
And I am on the "Service agreement" screen
When I click on "View" (Or "Daedalus" on macOS)
Then I can see the "Settings" option is disabled
And I can't access by the keyboard shortcut

Scenario 7 - Validate "About" is disabled is disabled on "Service Agreement" screen

Given Daedalus is executed for the first time after installation
And I am on the "Service agreement" screen
When I click on "Daedalus"
Then I can see the "About" option is disabled

Scenario 8 - Validate "Daedalus diagnostics" is disabled is disabled on "Service Agreement" screen

Given Daedalus is executed for the first time after installation
And I am on the "Service agreement" screen
When I click on "Help"
Then I can see the "Daedalus Diagnostics" option is disabled
And I can't access by the keyboard shortcut

Scenario 9 - Validate "Wallet settings" is enabled after agreeing on "Service Agreement" screen

Given Daedalus is executed for the first time after installation
And I have accepted the terms on "Service agreement" screen
When I click on "View" (Or "Daedalus" on macOS)
Then I can see the "Wallet settings" option is enabled
And I can access by the keyboard shortcut

Scenario 10 - Validate "Settings" is enabled after agreeing on "Service Agreement" screen

Given Daedalus is executed for the first time after installation
And I have accepted the terms on "Service agreement" screen
When I click on "View" (Or "Daedalus" on macOS)
Then I can see the "Settings" option is enabled
And I can access by the keyboard shortcut

Scenario 11 - Validate "About" is enabled after agreeing on "Service Agreement" screen

Given Daedalus is executed for the first time after installation
And I have accepted the terms on "Service agreement" screen
When I click on "Daedalus"
Then I can see the "About" option is enabled

Scenario 12 - Validate "Daedalus Diagnostics" is enabled after agreeing on "Service Agreement" screen

Given Daedalus is executed for the first time after installation
And I have accepted the terms on "Service agreement" screen
When I click on "Help"
Then I can see the "Daedalus Diagnostics" option is enabled
And I can access by the keyboard shortcut

Scenario 13 - Validate "Wallet Settings" is disabled after submitting initial settings and restarting Daedalus

Given Daedalus is executed for the first time after installation
And I am on the "Service agreement" screen
When I restart Daedalus
And I click on "View" (Or "Daedalus" on macOS)
Then I can see the "Wallet Settings" option is disabled
And I can't access by the keyboard shortcut

Scenario 14 - Validate "Settings" is disabled after submitting initial settings and restarting Daedalus

Given Daedalus is executed for the first time after installation
And I am on the "Service agreement" screen
When I restart Daedalus
And I click on "View" (Or "Daedalus" on macOS)
Then I can see the "Settings" option is disabled
And I can't access by the keyboard shortcut

Scenario 15 - Validate "About" is disabled after submitting initial settings and restarting Daedalus

Given Daedalus is executed for the first time after installation
And I am on the "Service agreement" screen
When I restart Daedalus
And I click on "Daedalus"
Then I can see the "About" option is disabled

Scenario 16 - Validate "Daedalus Diagnostics" is disabled after submitting initial settings and restarting Daedalus

Given Daedalus is executed for the first time after installation
And I am on the "Service agreement" screen
When I restart Daedalus
And I click on "Help"
Then I can see the "Daedalus Diagnostics" option is disabled
And I can't access by the keyboard shortcut

Testing Summary

English

Japanese

Review Checklist

Basics

Code Quality

Important parts of the code are properly commented and documented
Code is properly typed with flow
React components are split-up enough to avoid unnecessary re-renderings
Any code that only works in main process is neatly separated from components

Testing

New feature/change is covered by acceptance tests
New feature/change is manually tested and approved by QA team
All existing acceptance tests are still up-to-date
New feature/change is covered by Daedalus Testing scenario
All existing Daedalus Testing scenarios are still up-to-date

After Review

Merge the PR
Delete the source branch
Move the ticket to done column on the YouTrack board
Update Slack QA thread by marking it with a green checkmark

…ipped-by-accessing-to-settings

ManusMcCole · 2021-01-18T11:45:40Z

Hi @yakovkaravelov. Tested on build 15928. Works really well when on the Service Level Agreement screen. However Service Level Agreement can be skipped with scenario 1(If a wallet is saved in state directory from before) and 2 as these options are available still from the initial settings screen

Test cases	Results	Note
Scenario 1	Fail	Wallet Settings is still an available option from the initial settings screen and is not greyed out.
Scenario 2	Fail	Settings is still an available option from the initial settings screen. This option can be used as a way of bypassing the Service Level Agreement.video
Scenario 3	Fail	About Daedalus options is still available from the initial settings screen

topseniors · 2021-01-18T18:06:24Z

Hi @yakovkaravelov. Tested on build 15928. Works really well when on the Service Level Agreement screen. However Service Level Agreement can be skipped with scenario 1(If a wallet is saved in state directory from before) and 2 as these options are available still from the initial settings screen

Test cases Results Note
Scenario 1 Fail Wallet Settings is still an available option from the initial settings screen and is not greyed out.
Scenario 2 Fail Settings is still an available option from the initial settings screen. This option can be used as a way of bypassing the Service Level Agreement.video
Scenario 3 Fail About Daedalus options is still available from the initial settings screen

@ManusMcCole This was fixed. Please test again, thanks.

ManusMcCole

Goodjob Yakov. Looks good 👍

gabriela-ponce · 2021-01-19T13:54:20Z

The test cases were updated to validate "Daedalus Diagnostics" (cases 4, 8, 12) and also to validate all the options after submitting the initial settings and restarting Daedalus (cases 13 to 16).

@yakovkaravelov On build 15934 the cases 1 to 12 passed (pending to implement 13 to 16).

…of profile store

topseniors · 2021-01-20T09:23:20Z

@gnpf @nikolaglumac This is ready for review/test.
Thanks.

nikolaglumac

@yakovkaravelov please see my comments. Thanks!

source/renderer/app/stores/ProfileStore.js

source/main/index.js

topseniors · 2021-01-20T15:29:39Z

@nikolaglumac They were renamed, thanks.

source/main/index.js

…ipped-by-accessing-to-settings

nikolaglumac · 2021-01-21T07:57:38Z

@ManusMcCole please re-test this one 🙏

ManusMcCole

👍

nikolaglumac · 2021-01-21T09:55:27Z

source/renderer/app/stores/ProfileStore.js

+    await this.getTermsOfUseAcceptanceRequest.execute();
+    if (this.getTermsOfUseAcceptanceRequest.result) {
+      await enableApplicationMenuNavigationChannel.send();
+    } else {


@yakovkaravelov I don't think we need this else clause as the menu navigation is disabled by default?

nikolaglumac

@yakovkaravelov nice work!
Now with the latest changes, I believe we actually don't even need the "disable application menu channel". The navigation is disabled by default and we only need to enable it either when user accepts the terms of use OR if we detect the terms of use have already been accepted in the past.

source/main/index.js

nikolaglumac

Looks and works great now @yakovkaravelov 🎉

[DDW-536]: Disable certain menu items on terms of use page

73dd8e2

topseniors added chore ⏳release-vNext labels Jan 18, 2021

topseniors requested review from nikolaglumac, gabriela-ponce, DeeJayElly, ManusMcCole and miorsufianiohk January 18, 2021 08:58

topseniors self-assigned this Jan 18, 2021

topseniors added 2 commits January 18, 2021 01:00

[DDW-536]: Update changelog

6b2fc1e

Merge branch 'develop' into chore/ddw-536-service-agreement-can-be-sk…

3603096

…ipped-by-accessing-to-settings

[DDW-536]: Disable certain menus on initial settings screen as well

33b66e6

ManusMcCole approved these changes Jan 19, 2021

View reviewed changes

[DDW-536]: Fix terms of use page menu handling

cfab0c3

topseniors added the WIP label Jan 19, 2021

[DDW-536]: Handle menu items based on terms of use acceptance status …

8c159ea

…of profile store

topseniors removed the WIP label Jan 20, 2021

nikolaglumac suggested changes Jan 20, 2021

View reviewed changes

source/renderer/app/stores/ProfileStore.js Outdated Show resolved Hide resolved

source/renderer/app/stores/ProfileStore.js Outdated Show resolved Hide resolved

source/main/index.js Outdated Show resolved Hide resolved

[DDW-536]: Rename variables and functions for disabling menu items

472de76

nikolaglumac reviewed Jan 20, 2021

View reviewed changes

source/main/index.js Outdated Show resolved Hide resolved

gabriela-ponce approved these changes Jan 20, 2021

View reviewed changes

topseniors and others added 2 commits January 20, 2021 12:19

[DDW-536]: Update menu items initialization

8702ac0

Merge branch 'develop' into chore/ddw-536-service-agreement-can-be-sk…

87ca282

…ipped-by-accessing-to-settings

nikolaglumac requested a review from ManusMcCole January 21, 2021 07:57

[DDW-536] Updates CHANGELOG

9b7d180

ManusMcCole approved these changes Jan 21, 2021

View reviewed changes

nikolaglumac self-requested a review January 21, 2021 09:52

nikolaglumac reviewed Jan 21, 2021

View reviewed changes

nikolaglumac suggested changes Jan 21, 2021

View reviewed changes

nikolaglumac added the WIP label Jan 21, 2021

[DDW-536]: Remove unnecessary channel for disabling menu items

e9f81ce

nikolaglumac self-requested a review January 21, 2021 10:10

nikolaglumac removed the WIP label Jan 21, 2021

nikolaglumac added 2 commits January 21, 2021 11:13

[DDW-536] Updates CHANGELOG

27be39e

[DDW-536] Updates comment

625a4b2

nikolaglumac suggested changes Jan 21, 2021

View reviewed changes

source/main/index.js Outdated Show resolved Hide resolved

nikolaglumac added the WIP label Jan 21, 2021

[DDW-536]: Handle navigation enabling properly when rebuilding app menu

90ab56d

topseniors removed the WIP label Jan 21, 2021

nikolaglumac self-requested a review January 21, 2021 11:24

nikolaglumac approved these changes Jan 21, 2021

View reviewed changes

nikolaglumac merged commit c79b677 into develop Jan 21, 2021

iohk-bors bot deleted the chore/ddw-536-service-agreement-can-be-skipped-by-accessing-to-settings branch January 21, 2021 11:47

nikolaglumac added release-3.3.0 Daedalus Mainnet release-3.3.0-FC1 Daedalus Flight and removed ⏳release-vNext labels Feb 6, 2021

nikolaglumac mentioned this pull request Feb 17, 2021

Merge release/3.3.0 into master #2375

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DDW-536] Service agreement can be skipped by accessing to Settings #2304

[DDW-536] Service agreement can be skipped by accessing to Settings #2304

topseniors commented Jan 18, 2021 •

edited by gabriela-ponce

Loading

ManusMcCole commented Jan 18, 2021 •

edited

Loading

topseniors commented Jan 18, 2021

ManusMcCole left a comment

gabriela-ponce commented Jan 19, 2021

topseniors commented Jan 20, 2021 •

edited

Loading

nikolaglumac left a comment

topseniors commented Jan 20, 2021

nikolaglumac commented Jan 21, 2021

ManusMcCole left a comment

nikolaglumac Jan 21, 2021

nikolaglumac left a comment

nikolaglumac left a comment

[DDW-536] Service agreement can be skipped by accessing to Settings #2304

[DDW-536] Service agreement can be skipped by accessing to Settings #2304

Conversation

topseniors commented Jan 18, 2021 • edited by gabriela-ponce Loading

Todos

Testing Checklist

App

Test Cases

Testing Summary

Review Checklist

Basics

Code Quality

Testing

After Review

ManusMcCole commented Jan 18, 2021 • edited Loading

topseniors commented Jan 18, 2021

ManusMcCole left a comment

Choose a reason for hiding this comment

gabriela-ponce commented Jan 19, 2021

topseniors commented Jan 20, 2021 • edited Loading

nikolaglumac left a comment

Choose a reason for hiding this comment

topseniors commented Jan 20, 2021

nikolaglumac commented Jan 21, 2021

ManusMcCole left a comment

Choose a reason for hiding this comment

nikolaglumac Jan 21, 2021

Choose a reason for hiding this comment

nikolaglumac left a comment

Choose a reason for hiding this comment

nikolaglumac left a comment

Choose a reason for hiding this comment

topseniors commented Jan 18, 2021 •

edited by gabriela-ponce

Loading

ManusMcCole commented Jan 18, 2021 •

edited

Loading

topseniors commented Jan 20, 2021 •

edited

Loading