-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DDW-543] Update bignumber.js from v5 to v9 #2305
[DDW-543] Update bignumber.js from v5 to v9 #2305
Conversation
Implemented all breaking changes: https://github.com/MikeMcl/bignumber.js/blob/master/CHANGELOG.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @DominikGuzei .
The following are failures for build 16002:
Test cases | Results | Note |
---|---|---|
Scenario 2: Stake pool - Stake pools | Failed | When I selected this option, Daedalus went blank and TypeError: w.amount.greaterThanOrEqualTo is not a function displayed on console. Please see video attachment |
Scenario 2: Stake pool - Delegation centre | Failed | When I clicked on "Redelegate", Daedalus went blank and TypeError: walletAmount.equals is not a function at DelegationSetupWizardDialogContainer._this.handleIsWalletAcceptable displayed on console. Please see video attachment |
Scenario 2: Redeem ITN Rewards | Failed | During redeeming ITN reward, upon clicking 'Continue' button, the syncing animation showed, never went away and nothing happened. No console error. Please see video attachment |
@mioriohk I pushed some changes that should at least fix the issues regarding the stake pools scenarios 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on 16014 👍
This PR updates the dependency
bignumber.js
from version 5 to 9 and fixes all breaking API changes summarized here: https://github.com/MikeMcl/bignumber.js/blob/master/CHANGELOG.mdNote: there should not be any changes in the UX / UI anywhere.
This is a preparation PR for DDW-543 Support Any Number in Numeric Input since it makes sense to test this in advance.
Testing Checklist
Test Cases
Test Summary
Test results for build 16002
TypeError: w.amount.greaterThanOrEqualTo is not a function
displayed on console. Please see video attachmentTypeError: walletAmount.equals is not a function at DelegationSetupWizardDialogContainer._this.handleIsWalletAcceptable
displayed on console. Please see video attachmentReview Checklist
Basics
feature
/bug
/chore
,release-x.x.x
)yarn test
)yarn dev
)yarn package
/ CI builds)yarn flow:test
)yarn lint
)yarn prettier:check
)yarn manage:translations
produces no changes)yarn storybook
)yarn.lock
file is updatedCode Quality
Testing
After Review
done
column on the YouTrack board