Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDW-551] Adjust sorting on rewards screen #2333

Merged
merged 5 commits into from
Feb 3, 2021

Conversation

topseniors
Copy link
Contributor

@topseniors topseniors commented Feb 2, 2021

This PR adjusted sorting of table on rewards screen
Jira Ticket

Todos

  • Adjust sorting of table on rewards screen

Testing Checklist

Screenshots

English

image
image

Japanese

image
image

Test Cases

Scenario 1: Sort reward
Given I am on Staking -> Rewards screen
And there are at least 2 or more wallets displayed
And at least 2 wallets have different rewards amount
When I sort the rewards in (ascending|descending) order
Then they are sorted correctly

App

  • Go to Staking => Rewards and make sure sorting of table works properly whenever changing column and order

Review Checklist

Basics

  • PR has been assigned and has appropriate labels (feature/bug/chore, release-x.x.x)
  • PR is updated to the most recent version of the target branch (and there are no conflicts)
  • PR has a good description that summarizes all changes and shows some screenshots or animated GIFs of important UI changes
  • CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
  • Automated tests: All acceptance and unit tests are passing (yarn test)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn dev)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn package / CI builds)
  • There are no flow errors or warnings (yarn flow:test)
  • There are no lint errors or warnings (yarn lint)
  • There are no prettier errors or warnings (yarn prettier:check)
  • There are no missing translations (running yarn manage:translations produces no changes)
  • Text changes are proofread and approved (Jane Wild / Amy Reeve)
  • Japanese text changes are proofread and approved (Junko Oda)
  • UI changes look good in all themes (Alexander Rukin)
  • Storybook works and no stories are broken (yarn storybook)
  • In case of dependency changes yarn.lock file is updated

Code Quality

  • Important parts of the code are properly commented and documented
  • Code is properly typed with flow
  • React components are split-up enough to avoid unnecessary re-renderings
  • Any code that only works in main process is neatly separated from components

Testing

  • New feature/change is covered by acceptance tests
  • New feature/change is manually tested and approved by QA team
  • All existing acceptance tests are still up-to-date
  • New feature/change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review

  • Merge the PR
  • Delete the source branch
  • Move the ticket to done column on the YouTrack board
  • Update Slack QA thread by marking it with a green checkmark

Copy link
Contributor

@nikolaglumac nikolaglumac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix type declarations 🙏
The rest looks good.

Don't forget to add screenshots!

source/renderer/app/utils/sortComparators.js Show resolved Hide resolved
source/renderer/app/utils/sortComparators.js Show resolved Hide resolved
source/renderer/app/utils/sortComparators.js Show resolved Hide resolved
@topseniors topseniors removed the WIP label Feb 3, 2021
@topseniors
Copy link
Contributor Author

@nikolaglumac Fixed.
@mioriohk @gnpf This is ready for test, thanks.

Copy link
Contributor

@nikolaglumac nikolaglumac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Copy link

@miorsufianiohk miorsufianiohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 . Tested on 16224

@nikolaglumac nikolaglumac merged commit 49e17d1 into develop Feb 3, 2021
@iohk-bors iohk-bors bot deleted the chore/ddw-551-adjust-sorting-in-rewards branch February 3, 2021 11:47
@nikolaglumac nikolaglumac added release-3.3.0 Daedalus Mainnet release-3.3.0-FC1 Daedalus Flight and removed ⏳release-vNext labels Feb 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore release-3.3.0-FC1 Daedalus Flight release-3.3.0 Daedalus Mainnet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants