Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDW-456] Add missing space for amount + "ADA" [Japanese] #2380

Merged

Conversation

topseniors
Copy link
Contributor

@topseniors topseniors commented Feb 18, 2021

This PR added missing spaces for amount + "ADA" [Japanese] text contents
Jira Ticket

Todos

  • Add missing space for amount + "ADA" [Japanese] text contents

Testing Checklist

App

Configure Japanese in settings and make sure there is space between amount and ADA label in text contents in following scenarios

  • Go to Wallet => Transactions, export transactions list to CSV file and review CSV content
  • Go to Wallet => Utxo and review the screen text
  • Go to Redeem rewards and review validation message for source wallet with insufficient funds
  • Go to Staking => Stake pools delegation and review validation message for wallet with insufficient funds
  • Go to Staking => Stake pools delegation and review dialog message for no wallet with required funds
  • Go to Staking => Stake pools delegation and review unavailable message when there is no wallet

Test Cases

DDW 456

Given that Daedalus in Japanese for all scenerios

Scenario 1.Validate CSV File
Given that I have a wallet fully synced 
And it has transaction history
And I download CSV file from transactions tab
When I open the file
Then I should see a space between amount and ada label

Scenario2.Validate UTXO Distribution Screen
Given that I have a wallet fully synced 
And it has transaction history
When I navigate to the wallet utxo distribution screen
Then I will see a space between amount and ada label

Scenario 3.Validate Redemption Rewards Error Message
Given that I I have a wallet with less than 10 ada
And I attempt to redeem rewards in to it 
When I see the error message
Then I can confirm there is a space between ada amount and label

Scenario 4.Validate Redelegate Error Message
Given that I I have a wallet fully synced 
And  it has less than 10ada balance
When I attempt to redelegate and see the error message
Then I can confirm there is a space between amount and ada label

Scenario 5.Validate Redemption Rewards Error Dialog
Given that I I have a wallet fully synced 
And  it has less than 10ada balance
When I attempt to redelegate and see the error dialog
Then I can confirm there is a space between amount and ada label

Scenario 6.Validate Redemption Rewards Error Dialog
Given that I I have a wallet fully synced 
And  it has less than 10ada balance
And there is no wallet available
When I review unavailable message
Then I can confirm there is a space between amount and ada label

Screenshots

Japanese

image
image
image

Review Checklist

Basics

  • PR has been assigned and has appropriate labels (feature/bug/chore, release-x.x.x)
  • PR is updated to the most recent version of the target branch (and there are no conflicts)
  • PR has a good description that summarizes all changes and shows some screenshots or animated GIFs of important UI changes
  • CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
  • Automated tests: All acceptance and unit tests are passing (yarn test)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn dev)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn package / CI builds)
  • There are no flow errors or warnings (yarn flow:test)
  • There are no lint errors or warnings (yarn lint)
  • There are no prettier errors or warnings (yarn prettier:check)
  • There are no missing translations (running yarn manage:translations produces no changes)
  • Text changes are proofread and approved (Jane Wild / Amy Reeve)
  • Japanese text changes are proofread and approved (Junko Oda)
  • UI changes look good in all themes (Alexander Rukin)
  • Storybook works and no stories are broken (yarn storybook)
  • In case of dependency changes yarn.lock file is updated

Code Quality

  • Important parts of the code are properly commented and documented
  • Code is properly typed with flow
  • React components are split-up enough to avoid unnecessary re-renderings
  • Any code that only works in main process is neatly separated from components

Testing

  • New feature/change is covered by acceptance tests
  • New feature/change is manually tested and approved by QA team
  • All existing acceptance tests are still up-to-date
  • New feature/change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review

  • Merge the PR
  • Delete the source branch
  • Move the ticket to done column on the YouTrack board
  • Update Slack QA thread by marking it with a green checkmark

Copy link
Contributor

@DeeJayElly DeeJayElly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ @yakovkaravelov

Copy link
Contributor

@nikolaglumac nikolaglumac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nikolaglumac nikolaglumac merged commit b7ff224 into develop Feb 19, 2021
@iohk-bors iohk-bors bot deleted the chore/ddw-456-add-missing-space-for-amount-ada-japanese branch February 19, 2021 08:13
@nikolaglumac nikolaglumac added release-3.3.1 Daedalus Mainnet and removed ⏳release-vNext labels Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore release-3.3.1 Daedalus Mainnet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants