Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/deaf 388 Show error on sending money to redeem address #423

Merged

Conversation

nikolaglumac
Copy link
Contributor

@nikolaglumac nikolaglumac commented Aug 17, 2017

This PR implements more specific error message on sending money to Ada redemption address.

TODO

  • Inject missing Japanese translation for new error message:
"api.errors.NotAllowedToSendMoneyToRedeemAddressError": "It is not allowed to send money to Ada redemption address."

screen shot 2017-08-17 at 14 25 15

@mention-bot
Copy link

@nikolaglumac, thanks for your PR! By analyzing the history of the files in this pull request, we identified @tomothespian, @DominikGuzei and @darko-mijic to be potential reviewers.

@nikolaglumac
Copy link
Contributor Author

@darko-mijic @DominikGuzei to test this feature please use latest cardano-sl akegalj/daef406-tls-workaround (commit b428adc7c2515c5dfac27d77b09b1297874609fe).
Here are the Ada redemption addresses you should try sending money to in order to see this new error message:

2UYGXbAAHRgcPg1yYQ6nFH5t5mMfa8e97mmtJgwbYTqt4yX3vS1op8
2UYGXbAAHXszP3AMs1Pd3te4bTeXvAY23HDvNmRAJZ6d2jxQPfBc1r

Copy link
Member

@DominikGuzei DominikGuzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! 👍 merging now

@DominikGuzei DominikGuzei merged commit da037ea into master Aug 18, 2017
@nikolaglumac nikolaglumac deleted the fix/deaf-388-show-error-on-sending-money-to-redeem-address branch August 18, 2017 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants