-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/daef 301 Importing a wallet from a file #439
Merged
darko-mijic
merged 13 commits into
master
from
fix/daef-301-importing-a-wallet-from-a-file
Aug 30, 2017
Merged
Fix/daef 301 Importing a wallet from a file #439
darko-mijic
merged 13 commits into
master
from
fix/daef-301-importing-a-wallet-from-a-file
Aug 30, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…I endpoint for importing wallet
…ing-a-wallet-from-a-file # Conflicts: # CHANGELOG.md # app/i18n/locales/ja-JP.json
darko-mijic
approved these changes
Aug 30, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! And it works. ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces integration of "wallet name" field and updated API endpoint for importing wallet.
TODOs
.key
files)Once API endpoint is updated check if importBackupJSON endpoint flow-type declaration is correct:API update delayedMake sure this feature is working both with wallet JSON and wallet key file after API has been updatedAPI update delayed.key
and.json
files in the Front-End