Fix/daef 458 Wallet send form flicker on submit #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darko-mijic
approved these changes
Sep 7, 2017
darko-mijic
deleted the
fix/daef-458-wallet-send-form-flicker-on-submit
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a fix for transaction fees flicker/reset on Wallet send screen form submit.
The need for this kind of a fix is an indicator we should move fees-calculation logic away from the component and put it in the store. A task has been created for this refactoring: https://issues.serokell.io/issue/DAEF-459
Original issue recording: