Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/daef 468 Frontend AtoA transaction handling #484

Merged

Conversation

nikolaglumac
Copy link
Contributor

@nikolaglumac nikolaglumac commented Sep 18, 2017

This PR introduces improved error messages for transaction-fees-calculation endpoint.

TODO

  • Inject missing Japanese translation
"api.errors.AllFundsAlreadyAtReceiverAddressError": "All your funds are already at the address you are trying send money to.",

screen shot 2017-09-18 at 11 25 03
screen shot 2017-09-18 at 11 24 50

@DominikGuzei
Copy link
Member

Reviewing this now …

@DominikGuzei
Copy link
Member

DominikGuzei commented Sep 18, 2017

@nikolaglumac how can i reproduce this? I sent two transactions from "Genesis wallet" to two different addresses of itself (taken from receive screen) and it worked without any errors..

@DominikGuzei
Copy link
Member

I ran backend on cardano-sl-0.6--0.6.2-candidate (commit: 9f5b591e7365c9723cca02ee8fbb284957b0fb42) and started it with ./scripts/launch/connect-to-cluster/testnet-staging-0.6.sh

@nikolaglumac
Copy link
Contributor Author

@DominikGuzei here are the steps to reproduce both errors:

  1. A -> A error aka. All your funds are already at the address you are trying send money to.
  • import new Genesis wallet which has never been used before (aka. transaction history is empty and wallet has only single address)
  • try to send any amount to the single address of imported wallet
  1. A -> B error for sending too much money aka. Not enough Ada for fees.
  • use the same imported wallet from first step and try to send amount larger than the wallet's balance to some other wallet (eg. create/import/restore another wallet and use it's address as receiver)

I also used cardano-sl-0.6--0.6.2-candidate branch BUT I use ./scripts/launch/connect-to-cluster/testnet-0.6.sh script to launch it - but I don't think it should matter...

@DominikGuzei
Copy link
Member

@nikolaglumac i will push the missing translation now

Copy link
Member

@DominikGuzei DominikGuzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could reproduce both error cases and pushed the missing japanese translation 👍 ready to merge

@DominikGuzei
Copy link
Member

Closing this PR in favor of new target against release/0.8.2

@DominikGuzei DominikGuzei reopened this Sep 21, 2017
@DominikGuzei DominikGuzei merged commit 250c3a5 into master Sep 21, 2017
@nikolaglumac nikolaglumac deleted the fix/daef-468-frontend-a-to-a-transaction-handling branch October 26, 2017 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants