Remove maximum window size limitations #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Limiting setMaximumSize does not really serve a purpose. It is actually more annoying to not being able to maximize the window on a 13" retina display.
adlk
changed the title
DominikGuzei
approved these changes
Oct 9, 2017
There was a problem hiding this comment.
Thanks for the feedback @adlk, PR looks good - merging now! 👍
|
Not sure when this was planned but it was not done in correct manner... |
|
Thanks @nikolaglumac, didn't see that extra call … the magic numbers should also be turned into constants. |
|
@DominikGuzei since the plan is to remove these numbers we will not have anything to turn into constants :) |
|
Just sayin … 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limiting setMaximumSize does not really serve a purpose. It is actually more annoying to not being able to maximize the window on a 13" retina display.