Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/daef 524 update to latest Electron #541

Merged
merged 4 commits into from
Nov 20, 2017

Conversation

tomislavhoracek
Copy link
Contributor

This PR introduces update to latest electron.

Copy link
Contributor

@nikolaglumac nikolaglumac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems to be working. Great job @tomothespian ;)

@nikolaglumac
Copy link
Contributor

@darko-mijic @DominikGuzei please review this PR and do both manual end-to-end testing and acceptance-tests. This is a sensitive update and we must make sure everything is working ;)

@DominikGuzei
Copy link
Member

Testing this now …

Copy link
Member

@DominikGuzei DominikGuzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works on Mac and Windows 👍

@DominikGuzei DominikGuzei merged commit afa80d2 into master Nov 20, 2017
@DominikGuzei DominikGuzei deleted the chore/daef-524-update-to-latest-electron branch November 20, 2017 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants