Fix/daef 536 flow type introduced with web3 dependency #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikolaglumac
approved these changes
Nov 20, 2017
There was a problem hiding this comment.
Looks and works great @DominikGuzei!
I have just added few little eslint fixes and also fixed 3 of our acceptance tests that were failing (non-related to your update!).
Approved!
|
@DominikGuzei this PR can be merged as soon as CI passes. |
DominikGuzei
deleted the
fix/daef-536-flow-type-introduced-with-web3-dependency
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates to
"flow-bin": "0.59.0"and fixes all issues that emerged due to changes in the notation, especially for React components.No code has been changed in any logical way, apart from flow types and fixing errors that the new flow type checker found for us.