Fix/ddw 13 Fix all storybook issues #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikolaglumac
approved these changes
Dec 21, 2017
There was a problem hiding this comment.
@DominikGuzei there were some flow issues and also wrong imports which were crashing the app. I have fixed all now and also added a CHANGELOG entry.
This PR can be merged as soon as CI is finished.
Approved 👍
nikolaglumac
changed the title
nikolaglumac
deleted the
fix/DDW-13-fix-storybook-react-polymorph-styling-issues
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes all issue we had with storybook:
react-polymorphcorrectly (imported the pre-themed components instead ofraw)resolverlogic away fromTransactionandTopBarcomponents since we cannot use dynamic resolving within the browser! (that only works in node.js environments)