Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DEVOPS-533] mantis support in daedalus installer #657

Closed
wants to merge 15 commits into from
Closed

[DEVOPS-533] mantis support in daedalus installer #657

wants to merge 15 commits into from

Conversation

cleverca22
Copy link
Contributor

No description provided.

@domenkozar
Copy link
Contributor

@cleverca22 make sure to prepend DEVOPS-533 to commits and cleanup history.

@domenkozar domenkozar added the WIP label Jan 22, 2018
@darko-mijic darko-mijic mentioned this pull request Jan 31, 2018
Merged
@nikolaglumac
Copy link
Contributor

Hi @cleverca22 do you still need this PR?
If not I would like to ask you to close it and delete the branch.
OR if you need it please add DO-NOT-MERGE tag...
#springCleanup :)
Thanks!

@cleverca22
Copy link
Contributor Author

i think we need to remove the conflicting make-installer changes, and get the pure javascript/mantis stuff merged into develop, then i can redo the make-installer stuff against the most recent develop

@nikolaglumac
Copy link
Contributor

@cleverca22 develop already contains all the javascript for Mantis AFAIK. I think that only Mantis configuration DevOps specifics are missing...

@cleverca22
Copy link
Contributor Author

cleverca22 commented Apr 16, 2018 •
edited
Loading

ah, the bulk of the commits i'm seeing here are likely due to the target being master not develop, i'll see about redoing things when i get a chance

yeah, diff looks much better with a branch change

@cleverca22 cleverca22 changed the base branch from master to develop April 16, 2018 10:49
@nikolaglumac
Copy link
Contributor

Sounds like a plan @cleverca22!
I have assigned this PR to you and added DO-NOT-MERGE tag...

@nikolaglumac
Copy link
Contributor

@cleverca22 is this PR still needed? Can we close it and delete the branch?

@cleverca22 cleverca22 closed this Oct 3, 2018
@cleverca22 cleverca22 deleted the ddw-3 branch October 3, 2018 09:00
@nikolaglumac nikolaglumac removed the WIP label Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenkozar domenkozar Awaiting requested review from domenkozar

Assignees

@cleverca22 cleverca22

Labels
DO NOT MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cleverca22 @domenkozar @nikolaglumac