Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDW-70] Duplicate transaction ids for ETC #699

Conversation

nikolaglumac
Copy link
Contributor

@nikolaglumac nikolaglumac commented Jan 30, 2018

This PR fixes rendering issues when there are transactions with duplicated ids - such as when you create A -> A transaction. This problem is affecting only Daedalus/Mantis version.

screen shot 2018-01-30 at 22 51 00

Copy link
Member

@DominikGuzei DominikGuzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@nikolaglumac
Copy link
Contributor Author

This PR will remain in WIP and DO NOT MERGE until it is decided what should be the next release branch.

@nikolaglumac nikolaglumac changed the base branch from mantis-daedalus-rc1-3 to mantis-daedalus-1.1 February 9, 2018 10:41
@nikolaglumac nikolaglumac changed the title Fix/ddw 70 Duplicate transaction ids for ETC [DDW-70] Duplicate transaction ids for ETC May 27, 2018
@nikolaglumac nikolaglumac self-assigned this Jun 15, 2018
@DominikGuzei
Copy link
Member

@nikolaglumac i guess we can close this?

@nikolaglumac
Copy link
Contributor Author

@DominikGuzei yes - we already added this fix in our develop branch. Closing it now...

@nikolaglumac nikolaglumac deleted the fix/ddw-70-duplicate-transaction-ids-for-etc branch August 28, 2018 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants