Feature/ddw 220 Implement async wallet restore #849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ub.com:input-output-hk/daedalus into feature/ddw-220-implement-async-wallet-restore
…ub.com:input-output-hk/daedalus into feature/ddw-220-implement-async-wallet-restore
|
All acceptance tests are updated and all are now passing 🎉
|
nikolaglumac
requested review from
DominikGuzei,
darko-mijic and
tomislavhoracek
|
@darko-mijic @DominikGuzei @tomothespian this PR is now ready for the review! |
|
PS. I will post details of how to run Cardano-SL |
tomislavhoracek
previously approved these changes
Apr 12, 2018
DominikGuzei
requested changes
Apr 12, 2018
| // Reject errors | ||
| response.on('error', (error) => reject(error)); | ||
| // Resolve JSON results and handle weird backend behavior | ||
| // of "Left" (for errors) and "Right" (for success) properties |
There was a problem hiding this comment.
This comment should be removed as it is not the case here anymore!
| if (!wallets.active) return <MainLayout><LoadingSpinner /></MainLayout>; | ||
|
|
||
| const isRestoreActive = get(wallets.active, 'syncState.tag') === 'restoring'; |
There was a problem hiding this comment.
It would be good to refactor this into proper api TYPES instead of magic constants.
| @@ -30,6 +31,8 @@ export default class WalletSendPage extends Component<Props> { | |||
| // Guard against potential null values | |||
| if (!activeWallet) throw new Error('Active wallet required for WalletSendPage.'); | |||
|
|
|||
| const isRestoreActive = get(activeWallet, 'syncState.tag') === 'restoring'; | |||
There was a problem hiding this comment.
same here -> using proper api types instead of 'restoring' string
| @@ -51,7 +52,9 @@ export default class WalletSummaryPage extends Component<Props> { | |||
| let walletTransactions = null; | |||
| const noTransactionsLabel = intl.formatMessage(messages.noTransactions); | |||
|
|
|||
| if (recentTransactionsRequest.isExecutingFirstTime || hasAny) { | |||
| const isRestoreActive = get(wallet, 'syncState.tag') === 'restoring'; | |||
|
@DominikGuzei all your comments are now fixed! |
DominikGuzei
approved these changes
Apr 12, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the implementation of asynchronous wallet restoration and import features.
This is a
majorimprovement as the wallet which is being restored/imported is momentarily available in the UI. User is able to straight away see the wallet's balance and existing wallet addresses while wallet transaction history is being fetched in the background. During the restoration process details are shown: restoration progress percentage and estimated time of completion. It is not possible to send new transactions during the entire restoration process.TODOs:
Summary screen
Send screen
Transactions screen