Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDW-300] Increase wallets limit to 50 #958

Merged

Conversation

nikolaglumac
Copy link
Contributor

@nikolaglumac nikolaglumac commented Jun 4, 2018

Fixed presentation bug that caused only ten wallets to be shown in the wallets list, even though there were more than ten wallets in the application.

This PR CHANGES.

Todo:

  • Inject missing Japanese translations

Screenshots:

message


Review Checklist:

Basics

  • PR is updated to the most recent version of target branch (and there are no conflicts)
  • PR has good description that summarizes all changes and shows some screenshots or animated GIFs of important UI changes
  • CHANGELOG entry has been added and is linked to the correct PR on GitHub
  • Automated tests: All acceptance tests are passing (npm run test)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (npm run dev)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (npm run package / CI builds)
  • There are no flow errors or warnings (npm run flow:test)
  • There are no lint errors or warnings (npm run lint)
  • Text changes are proofread and approved (Jane Wild)
  • There are no missing translations (running npm run manage:translations produces no changes)
  • UI changes look good in all themes (Alexander Rukin)
  • Storybook works and no stories are broken (npm run storybook)
  • In case of npm dependency changes both package-lock.json and yarn.lock files are updated

Code Quality

  • Important parts of the code are properly documented and commented
  • Code is properly typed with flow
  • React components are split-up enough to avoid unnecessary re-rendering
  • Any code that only works in Electron is neatly separated from components

Testing

  • New feature / change is covered by acceptance tests
  • All existing acceptance tests are still up-to-date
  • New feature / change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review:

  • Merge PR
  • Delete source branch
  • Move ticket to done on the Youtrack board

…tion for maximum wallets count reached situation
@nikolaglumac nikolaglumac removed the WIP label Jun 5, 2018
@nikolaglumac
Copy link
Contributor Author

@darko-mijic @DominikGuzei this PR is now ready to be reviewed.

Copy link
Member

@DominikGuzei DominikGuzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 👍
We should add a card for writing an acceptance test for the limit.

@nikolaglumac
Copy link
Contributor Author

@DominikGuzei already done: https://iohk.myjetbrains.com/youtrack/issue/DDW-302

@DominikGuzei DominikGuzei merged commit a60a912 into release/0.10.1 Jun 5, 2018
@DominikGuzei DominikGuzei deleted the fix/ddw-300-increase-wallets-limit-to-50 branch June 5, 2018 15:39
@nikolaglumac nikolaglumac mentioned this pull request Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants