[DEVOPS-888] set a logs prefix for launcher #963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cleverca22 shouldn't we target the |
deepfire
previously approved these changes
Jun 6, 2018
|
@cleverca22 that is a wrong target branch - please use |
nikolaglumac
suggested changes
Jun 6, 2018
There was a problem hiding this comment.
@cleverca22 please add CHANGELOG entry for this important fix:
Fixed missing launcher log file
nikolaglumac
previously approved these changes
Jun 6, 2018
deepfire
approved these changes
Jun 6, 2018
nikolaglumac
approved these changes
Jun 6, 2018
|
@cleverca22 feel free to merge this one as soon as CI is done... |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the missing launcher log files.
Todo:
LinuxmacOSWindows