Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDW-317] Font display improvements #973

Merged
merged 1 commit into from
Jun 13, 2018

Conversation

nikolaglumac
Copy link
Contributor

@nikolaglumac nikolaglumac commented Jun 13, 2018

This PR improves text display by reducing letter-spacing.

Since a new NotoSans font was introduced we need to slightly modify the letter-spacing in order to make the new font look more compact and to save space.
We need to do the following:

  • remove global body CSS letter-spacing: 1px rule
  • change Dialog title CSS letter-spacing from 2px to 1px
  • add word-spacing: 2px to Mnemonics box on both Wallet create and Paper wallet create dialogs

Screenshots:

Old

screen shot 2018-06-13 at 12 44 47

New

screen shot 2018-06-13 at 12 51 59

Old

screen shot 2018-06-13 at 12 44 52

New

screen shot 2018-06-13 at 12 52 10

Old

screen shot 2018-06-13 at 12 44 58

New

screen shot 2018-06-13 at 12 52 20

Old

screen shot 2018-06-13 at 12 45 04

New

screen shot 2018-06-13 at 12 52 26


Review Checklist:

Basics

  • PR is updated to the most recent version of target branch (and there are no conflicts)
  • PR has good description that summarizes all changes and shows some screenshots or animated GIFs of important UI changes
  • CHANGELOG entry has been added and is linked to the correct PR on GitHub
  • Automated tests: All acceptance tests are passing (npm run test)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (npm run dev)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (npm run package / CI builds)
  • There are no flow errors or warnings (npm run flow:test)
  • There are no lint errors or warnings (npm run lint)
  • Text changes are proofread and approved (Jane Wild)
  • There are no missing translations (running npm run manage:translations produces no changes)
  • UI changes look good in all themes (Alexander Rukin)
  • Storybook works and no stories are broken (npm run storybook)
  • In case of npm dependency changes both package-lock.json and yarn.lock files are updated

Code Quality

  • Important parts of the code are properly documented and commented
  • Code is properly typed with flow
  • React components are split-up enough to avoid unnecessary re-rendering
  • Any code that only works in Electron is neatly separated from components

Testing

  • New feature / change is covered by acceptance tests
  • All existing acceptance tests are still up-to-date
  • New feature / change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review:

  • Merge PR
  • Delete source branch
  • Move ticket to done on the Youtrack board

Copy link
Contributor

@alexander-rukin alexander-rukin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@nikolaglumac nikolaglumac merged commit 812c08d into develop Jun 13, 2018
@nikolaglumac nikolaglumac deleted the chore/ddw-317-font-display-improvements branch June 13, 2018 11:46
@nikolaglumac nikolaglumac mentioned this pull request Jun 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants