Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to typed-protocols 0.3.0.0 #35

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Update to typed-protocols 0.3.0.0 #35

merged 1 commit into from
Oct 30, 2024

Conversation

Icelandjack
Copy link
Contributor

@Icelandjack Icelandjack commented Oct 18, 2024 •
edited
Loading

Update ekg-forward to the latest version of typed-protocols-0.3.

@Icelandjack Icelandjack marked this pull request as draft October 18, 2024 02:20
@Icelandjack Icelandjack force-pushed the baldurb/ekg-forward branch 13 times, most recently from 7098b40 to 82bb597 Compare October 29, 2024 11:43
@Icelandjack Icelandjack requested review from mgmeier and coot October 29, 2024 15:38
@Icelandjack Icelandjack marked this pull request as ready for review October 29, 2024 15:38
mgmeier
mgmeier requested changes Oct 29, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
ekg-forward.cabal Show resolved Hide resolved
coot
coot approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@coot coot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/System/Metrics/Protocol/Forwarder.hs Outdated Show resolved Hide resolved
mgmeier
mgmeier approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@mgmeier mgmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Icelandjack

@mgmeier mgmeier added this pull request to the merge queue Oct 30, 2024
Merged via the queue into master with commit 62a82eb Oct 30, 2024
3 checks passed
This was referenced Oct 30, 2024
Closed
Closed
@coot coot mentioned this pull request Nov 8, 2024
Open
8 tasks
@coot coot deleted the baldurb/ekg-forward branch November 18, 2024 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgmeier mgmeier mgmeier approved these changes

@coot coot coot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Icelandjack @coot @mgmeier