-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make DLLs in deps available to wine TH runner #1405
Conversation
This is a better fix to the problem of making DLLs available to the process running in wine that is used to evaluate TH code when cross compiling for Windows.
bors try |
tryBuild failed: |
bors try |
bors try- |
bors try |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable, just could do with some more comments!
tryTimed out. |
bors try |
tryBuild succeeded: |
Co-authored-by: Michael Peyton Jones <michael.peyton-jones@iohk.io>
bors try |
tryBuild failed: |
I've checked that this PR fixes #1402 and that it still works for IntersectMBO/plutus#4368. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
Would this fix #1098? It sounds like it? I've been using a bash script to use TH splices to work around this for over a year. So I'm very interested in fixing it. If you want, I can see if this PR fixes my issue? EDIT: I tried it and I don't get any SDL.dll errors..but my build does seem to still hang entirely on the first invocation of TH. Not sure if it's related to this (or even a haskell.nix issue to begin with). I'll try to make a minimal repro in any case. |
Seems plausible! It's weird that it's hanging, though. From that issue, it sounds like you got the hang in the past also when you hacked it up to get the library to the right place. So it looks like we've again progressed to that point, and we are stuck with the mystery of the hanging. |
bors try |
tryTimed out. |
bors try |
tryTimed out. |
This is a better fix to the problem of making DLLs available to the process running in wine that is used to evaluate TH code when cross compiling for Windows.