Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DLLs in deps available to wine TH runner #1405

Merged
merged 12 commits into from
Mar 25, 2022
Merged

Make DLLs in deps available to wine TH runner #1405

merged 12 commits into from
Mar 25, 2022

Conversation

hamishmack
Copy link
Collaborator

This is a better fix to the problem of making DLLs available to the process running in wine that is used to evaluate TH code when cross compiling for Windows.

This is a better fix to the problem of making DLLs available to the process running in wine that is used to evaluate TH code when cross compiling for Windows.
@hamishmack
Copy link
Collaborator Author

bors try

iohk-bors bot added a commit that referenced this pull request Mar 17, 2022
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Mar 17, 2022

try

Build failed:

@hamishmack
Copy link
Collaborator Author

bors try

iohk-bors bot added a commit that referenced this pull request Mar 17, 2022
@hamishmack
Copy link
Collaborator Author

bors try-

@hamishmack
Copy link
Collaborator Author

bors try

iohk-bors bot added a commit that referenced this pull request Mar 17, 2022
Copy link
Collaborator

@michaelpj michaelpj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable, just could do with some more comments!

overlays/mingw_w64.nix Outdated Show resolved Hide resolved
builder/comp-builder.nix Show resolved Hide resolved
overlays/mingw_w64.nix Outdated Show resolved Hide resolved
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Mar 17, 2022

try

Timed out.

@hamishmack
Copy link
Collaborator Author

bors try

iohk-bors bot added a commit that referenced this pull request Mar 18, 2022
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Mar 18, 2022

@hamishmack
Copy link
Collaborator Author

bors try

iohk-bors bot added a commit that referenced this pull request Mar 18, 2022
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Mar 18, 2022

try

Build failed:

@hamishmack
Copy link
Collaborator Author

I've checked that this PR fixes #1402 and that it still works for IntersectMBO/plutus#4368.

Copy link
Collaborator

@michaelpj michaelpj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@ramirez7
Copy link
Contributor

ramirez7 commented Mar 19, 2022

Would this fix #1098? It sounds like it?

I've been using a bash script to use TH splices to work around this for over a year. So I'm very interested in fixing it. If you want, I can see if this PR fixes my issue?

EDIT: I tried it and I don't get any SDL.dll errors..but my build does seem to still hang entirely on the first invocation of TH. Not sure if it's related to this (or even a haskell.nix issue to begin with). I'll try to make a minimal repro in any case.

@michaelpj
Copy link
Collaborator

Would this fix #1098? It sounds like it?

Seems plausible! It's weird that it's hanging, though. From that issue, it sounds like you got the hang in the past also when you hacked it up to get the library to the right place. So it looks like we've again progressed to that point, and we are stuck with the mystery of the hanging.

@michaelpj
Copy link
Collaborator

bors try

iohk-bors bot added a commit that referenced this pull request Mar 23, 2022
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Mar 23, 2022

try

Timed out.

@hamishmack
Copy link
Collaborator Author

bors try

iohk-bors bot added a commit that referenced this pull request Mar 24, 2022
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Mar 25, 2022

try

Timed out.

@hamishmack hamishmack merged commit 4b6ee97 into master Mar 25, 2022
@iohk-bors iohk-bors bot deleted the hkm/th-dlls branch March 25, 2022 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants