Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chore] update scalatest #689

Merged
merged 3 commits into from
Sep 25, 2020
Merged

[Chore] update scalatest #689

merged 3 commits into from
Sep 25, 2020

Conversation

kapke
Copy link
Contributor

@kapke kapke commented Sep 22, 2020

Description

Since ScalaTest is much more modular in 3.2, and it offers scalafix rules to automate the migration there's no reason not to do it.

PS. Besides dependencies the only changes made are:

  • autoformatting in some files which had to be touched manually (basically all additional test-based configurations)
  • rewrite of imports of *Suite, *Spec and Matchers
  • in PersonalServiceSpec - array matcher using Scalamock needed to be updated
  • repo.nix

Testing

Everything should compile and all tests should pass

@kapke kapke self-assigned this Sep 22, 2020
@kapke kapke added the update dependencies notify if is required to update nix dependencies or run sbt clean before compile the code label Sep 22, 2020
@lemastero
Copy link
Contributor

LGTM 👍 Only non-trivial change is in PersonalServiceSpec
PS @kapke there are conflicts

@kapke kapke force-pushed the chore-update-scalatest branch 2 times, most recently from 2e41442 to 3e1047d Compare September 24, 2020 14:30
@lemastero lemastero mentioned this pull request Sep 25, 2020
Closed
@kapke kapke merged commit 7d7fd4e into develop Sep 25, 2020
@dzajkowski dzajkowski deleted the chore-update-scalatest branch April 9, 2021 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemastero lemastero lemastero approved these changes

@KonradStaniec KonradStaniec KonradStaniec approved these changes

@pslaski pslaski Awaiting requested review from pslaski

Assignees

@kapke kapke

Labels
update dependencies notify if is required to update nix dependencies or run sbt clean before compile the code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kapke @lemastero @KonradStaniec