This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
[CAD-1397] ITN Ticker protection for mainnet and SMASH #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename TxMetadata to PoolMetadata because that is the actual pool metadata. It's nothing to do with transactions (and it's really confusing since Shelley also really does have transaction metadata). Rename PoolMetaData to PoolMetadataReference because this is _not_ the pool metadata, but the reference/pointer to the pool metadata. It has the URL and expected hash of the actual pool metadata.
|
What about implementing --> https://cardano-community.github.io/guild-operators/#/Scripts/itnwitness ? |
|
@KtorZ I saw that. This is the first implementation since we need to have something ASAP. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.iohk.io/browse/CAD-1397
A very quick implementation of the ticker issue.
Tested and it works.
Also refactored quite a bit, and fixed some things that I found.
Example for inserting ticker name:
Example for inserting the pool (changed):