Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

CAD-1449 Add asynchronous updating of offline metadata #40

Merged
merged 2 commits into from
Aug 6, 2020
Merged

CAD-1449 Add asynchronous updating of offline metadata #40

merged 2 commits into from
Aug 6, 2020

Conversation

erikd
Copy link
Member

@erikd erikd commented Aug 6, 2020 •
edited
Loading

I would prefer not to merge this before QA has looked at it.

@erikd erikd force-pushed the erikd/hacking-4 branch 5 times, most recently from 17df22b to f2d5257 Compare August 6, 2020 07:58
ksaric
ksaric suggested changes Aug 6, 2020
View reviewed changes
Copy link
Contributor

@ksaric ksaric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The panic in the Lib should be removed, otherwise will approve.

src/Lib.hs Outdated Show resolved Hide resolved
test/SmashSpecSM.hs Outdated Show resolved Hide resolved
src/DbSyncPlugin.hs Show resolved Hide resolved
@erikd
Copy link
Member Author

erikd commented Aug 6, 2020

The panic in Lib is in a function that is never used when Postgres is the backend. It also relies on functionality provided by Persistent/Postgres and its better to leave the panic than fake something that will actually be wrong.

@erikd @ksaric
Add asynchronous updating of offline metadata
5a1cdc5 
All offline metadata is tried synchronously with block retrieval. Requests
that fail are then tried asynchonously. Requests than need to be retried
are queried from the database and retries are back off exponentially with
a ceiling of daily retries. The retry interval for all offline metadata
is reduced to 60 seconds when the program is restarted.
ksaric
ksaric approved these changes Aug 6, 2020
View reviewed changes
Copy link
Contributor

@ksaric ksaric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, tested with MC4, other then it not being fully async, seems to work properly.

@ksaric
Copy link
Contributor

ksaric commented Aug 6, 2020

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 6, 2020

Build succeeded

@iohk-bors iohk-bors bot merged commit 49780cb into master Aug 6, 2020
@iohk-bors iohk-bors bot deleted the erikd/hacking-4 branch August 6, 2020 10:02
@erikd erikd mentioned this pull request Aug 8, 2020
Closed
@vhulchenko-iohk vhulchenko-iohk changed the title Add asynchronous updating of offline metadata CAD-1449 Add asynchronous updating of offline metadata Aug 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ksaric ksaric ksaric approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erikd @ksaric