refactor: remove support for client registration access tokens #2151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 344e923:
|
ThisIsMissEm
force-pushed
the
refactor/remove-support-for-registration-access-token
branch
from
84f1896
to
601d2bc
Compare
ThisIsMissEm
force-pushed
the
refactor/remove-support-for-registration-access-token
branch
from
9e7787b
to
dfc40c2
Compare
ThisIsMissEm
force-pushed
the
refactor/remove-support-for-registration-access-token
branch
from
dfc40c2
to
144d324
Compare
ThisIsMissEm
commented
May 20, 2022
ThisIsMissEm
force-pushed
the
refactor/remove-support-for-registration-access-token
branch
from
144d324
to
96da9f1
Compare
ThisIsMissEm
force-pushed
the
refactor/remove-support-for-registration-access-token
branch
from
8e38f2a
to
96da9f1
Compare
ThisIsMissEm
force-pushed
the
refactor/remove-support-for-registration-access-token
branch
from
96da9f1
to
d0e7a59
Compare
ThisIsMissEm
commented
May 31, 2022
| of a [Public Client Identifier | ||
| Document](https://docs.inrupt.com/developer-tools/javascript/client-libraries/tutorial/authenticate-client/) | ||
| - We've also removed support for the iframe-based session renewal, which was | ||
| never fully implemented. |
There was a problem hiding this comment.
@nicolasmondada does the above look good to you?
This feature wasn't fully implemented and doesn't really make sense in the context of solid, so we've removed it
ThisIsMissEm
force-pushed
the
refactor/remove-support-for-registration-access-token
branch
from
756c1e0
to
344e923
Compare
ThisIsMissEm
deleted the
refactor/remove-support-for-registration-access-token
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature wasn't fully implemented and doesn't really make sense in the context of solid, so we've removed it
Checklist
index.ts, if applicable.