Remove reference to window.localstorage from Session constructor #2159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9ce46c4:
|
A temporary fix was put into place in 3fd7bb4 which cleared a localstorage value set by a temporary ESS session restoration workflow. This caused window to be accessed in the session constructor, which caused issues with server-side rendering. The localstorage value no longer needs to be cleared as it is unused, so this line has been removed.
ajacksified
force-pushed
the
fix/remove-window-from-constructor
branch
from
55b96fe
to
9ce46c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A temporary fix was put into place in 3fd7bb4 which cleared a localstorage value set by a temporary ESS session restoration workflow. This caused window to be accessed in the session constructor, which caused issues with server-side rendering.
The localstorage value no longer needs to be cleared as it is unused, so this line has been removed.
This PR fixes bug #.