Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Sonar from running on dependabot PRs #2193

Merged
merged 1 commit into from
Jul 4, 2022
Merged

Conversation

NSeydoux
Copy link
Contributor

Since Sonar requires access to environment secrets, it cannot run on dependabot PRs

Since Sonar requires access to environment secrets, it cannot run on dependabot PRs
@NSeydoux NSeydoux requested a review from a team as a code owner June 28, 2022 08:23
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f8ec3ee:

Sandbox Source
solid-client-auth-browser-demo Configuration

@vercel vercel bot temporarily deployed to Preview June 28, 2022 08:27 Inactive
Copy link
Contributor

@ThisIsMissEm ThisIsMissEm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with this for now, but let's align with @edwardsph on this, I think using a dependabot secret could be the solution here

@NSeydoux NSeydoux merged commit 979c0ee into main Jul 4, 2022
@NSeydoux NSeydoux deleted the fix/sonar-dependabot branch July 4, 2022 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants