Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass through fetch to getWellKnownSolid #350

Merged
merged 4 commits into from
Aug 19, 2022

Conversation

ThisIsMissEm
Copy link
Contributor

This PR fixes the other part of SDK-2780, this PR is related to inrupt/solid-client-js#1680.

  • I've added a unit test to test for potential regressions of this bug.
  • The changelog has been updated, if applicable.
  • Commits in this PR are minimal and have descriptive commit messages.

@ThisIsMissEm ThisIsMissEm requested a review from a team as a code owner August 17, 2022 18:40
@vercel
Copy link

vercel bot commented Aug 17, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
solid-client-notifications-js ✅ Ready (Inspect) Visit Preview Aug 19, 2022 at 0:51AM (UTC)

@vercel vercel bot temporarily deployed to Preview August 17, 2022 18:40 Inactive
Copy link
Contributor

@jeswr jeswr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ThisIsMissEm ThisIsMissEm temporarily deployed to ESS PodSpaces Next August 19, 2022 12:50 Inactive
@ThisIsMissEm ThisIsMissEm temporarily deployed to ESS PodSpaces Next August 19, 2022 12:50 Inactive
@vercel vercel bot temporarily deployed to Preview August 19, 2022 12:51 Inactive
@ThisIsMissEm ThisIsMissEm merged commit 2221893 into main Aug 19, 2022
@ThisIsMissEm ThisIsMissEm deleted the fix/get-well-known-solid-fetch-issue branch August 19, 2022 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants