Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor DownloadTextFile #25

Merged
merged 4 commits into from
Feb 15, 2024
Merged

Conversation

walkowif
Copy link
Contributor

@walkowif walkowif commented Feb 15, 2024

Refactor DownloadTextFile so that the success/failure is determined by the presence/lack of error, and not HTTP status code/-1.

Copy link

github-actions bot commented Feb 15, 2024

Unit Tests Summary

14 tests   14 ✅  0s ⏱️
 2 suites   0 💤
 1 files     0 ❌

Results for commit 55c3b1c.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Feb 15, 2024

badge

Code Coverage Summary

Filename            Stmts    Miss  Cover    Missing
----------------  -------  ------  -------  ---------------------------------------------------------
cmd/construct.go      216      25  88.43%   72-83, 182-189, 222-224, 309-311
cmd/download.go       177      44  75.14%   52-77, 96-98, 115-117, 144-146, 162-164, 184-186, 227-233
cmd/parse.go          116      10  91.38%   36-42, 66-68
cmd/renv.go           214      60  71.96%   130-160, 289-325
cmd/root.go           145     142  2.07%    54-161, 168-217
cmd/utils.go           76      28  63.16%   52-63, 71-73, 81-83, 94-96, 117-123
TOTAL                 944     309  67.27%

Diff against main

Filename           Stmts    Miss  Cover
---------------  -------  ------  -------
cmd/download.go       +3      +3  -1.30%
TOTAL                 +3      +3  -0.21%

Results for commit: 55c3b1c

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@walkowif walkowif marked this pull request as ready for review February 15, 2024 13:54
@walkowif walkowif requested a review from a team as a code owner February 15, 2024 13:54
@walkowif walkowif merged commit 6a26580 into main Feb 15, 2024
10 checks passed
@walkowif walkowif deleted the refactor-download-text-file-function branch February 15, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants