Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect dependencies on 0.16 release #117

Closed
coderanger opened this issue Nov 11, 2016 · 4 comments
Closed

Incorrect dependencies on 0.16 release #117

coderanger opened this issue Nov 11, 2016 · 4 comments

Comments

@coderanger
Copy link
Contributor

This patch was included in 0.16, but that requires functionality only added to InSpec in 0.34. The current dependency on kitchen-inspec is >= 0.22, which is incorrect. We should yank the existing 0.16.0 and release a 0.16.1 with the correct InSpec dependency.

@coderanger
Copy link
Contributor Author

Also re: why I am recommended a yank, I do some testing on older ChefDK's to ensure compat, so if we do a new release but don't remove the broken 0.16.0, bundler/rubygems will happily try installing that version instead of the fixed one.

coderanger added a commit to poise/poise-hoist that referenced this issue Nov 11, 2016
@chris-rock
Copy link
Collaborator

Thanks for finding that issue @coderanger Would you like to put up a PR for that?

chris-rock added a commit that referenced this issue Nov 11, 2016
@coderanger
Copy link
Contributor Author

The actual patch seemed easy enough to not be needed :) The complex bits are the new release and the yank.

alexpop added a commit that referenced this issue Nov 11, 2016
@chris-rock
Copy link
Collaborator

Thanks @coderanger all fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants