Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add host and port config options #110

Merged
merged 1 commit into from
Nov 2, 2016
Merged

Add host and port config options #110

merged 1 commit into from
Nov 2, 2016

Conversation

alexpop
Copy link
Contributor

@alexpop alexpop commented Oct 25, 2016

When using kitchen vagrant, inspec is targeting 127.0.0.1 with the forwarded port provided by kitchen:

$ kitchen verify
-----> Starting Kitchen (v1.13.2)
-----> Verifying <mysuite-centos6>...
       Use `/Users/apop/git/myapache-cookbook/test/integration/mysuite` for testing

Target:  ssh://root@127.0.0.1:2222

This prevents resources like ssl from getting a real host they can connect to. This PR adds two config options to be able to specify the host and port to be used by inspec instead on relying on the kitchen ones. Output:

$ be kitchen verify
-----> Starting Kitchen (v1.6.0)
-----> Verifying <mysuite-centos6>...
       Use `/Users/apop/git/myapache-cookbook/test/integration/mysuite` for testing

Target:  ssh://root@192.168.33.40:22

  SSL/TLS on
     ✔  192.168.33.40:443 with protocol == "tls1.2" should be enabled

Copy link
Collaborator

@chris-rock chris-rock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @alexpop

Signed-off-by: Alex Pop <apop@chef.io>
@chris-rock chris-rock added this to the 0.16.0 milestone Oct 31, 2016
@chris-rock
Copy link
Collaborator

Nice @alexpop works like a charm

@chris-rock chris-rock merged commit 035e9a5 into master Nov 2, 2016
@chris-rock chris-rock deleted the ap/host-port-config branch November 2, 2016 22:58
@tas50 tas50 added Type: Enhancement Adds new functionality. and removed enhancement labels Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Adds new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants