Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the 'reporter' configuration option to kitchen-inspec #183

Merged
merged 1 commit into from
May 23, 2018
Merged

Add the 'reporter' configuration option to kitchen-inspec #183

merged 1 commit into from
May 23, 2018

Conversation

tim-pringle
Copy link
Contributor

@tim-pringle tim-pringle commented Apr 12, 2018

Signed-off-by: Tim Pringle tim.pringle@poweshell.amsterdam

The --format option is being being deprecated and will be removed in inspec 3.0.
This change allows the use of the --reporter parameter in a Kitchen config file.
Usage example:

verifier:
  name: inspec
  reporter:
    - progress
    - json:/tmp/json.txt

NB: Unlike 'format', 'reporter' is always parsed as a collection. As such it must be written appropriately in your .yml file when there is only one parameter as well.

verifier:
  name: inspec
  reporter:
    - progress

Signed-off-by: Tim Pringle <tim.pringle@poweshell.amsterdam>
@tim-pringle tim-pringle requested a review from a team as a code owner April 12, 2018 10:07
Copy link
Contributor

@jquick jquick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @tim-pringle !

@danielcbright
Copy link

Hi @jquick, I'm curious what else is needed to get this PR approved/merged? I've tested this branch locally with good results. Thanks!

@jquick
Copy link
Contributor

jquick commented May 14, 2018

@danielcbright - Hey, ill see if I can get another approval and get some of these pushed out and released this week. Thanks for the push.

@qvallance
Copy link

Thanks for creating this PR! Looks like it addresses #177 and is ready to go. Is there anything further needed to get the additional approval?

@jquick
Copy link
Contributor

jquick commented May 23, 2018

Thanks guys, merging now but we wont be able to have a new version pushed out till next week after ChefConf.

@jquick jquick merged commit e0de2c4 into inspec:master May 23, 2018
@tim-pringle tim-pringle deleted the dev_addreporter branch May 24, 2018 06:57
@b-dean
Copy link

b-dean commented Aug 17, 2018

Is there some way to make the reporter filename based on platform and suite names?

Also, this might make #137 obsolete

@wiebe
Copy link
Contributor

wiebe commented Aug 22, 2018

@b-dean i missed that too, see #198 :-)

jquick pushed a commit that referenced this pull request Sep 6, 2018
Since #183 the reporter feature can and should be used to define the InSpec output.

Signed-off-by: Lukas Schmidt <Lukas.Schmidt@kisters.de>
@chris-rock
Copy link
Collaborator

Here is an example how you can generate names more flexible:

    verifier:
      reporter:
        - progress
        - junit:/tmp/%{platform}_%{suite}_inspec.xml
        - json:/tmp/%{platform}_%{suite}_inspec.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants