Add ability to disable input caching in InSpec #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Heinen <theinen@tecracer.de>
4 tasks
lib/kitchen/verifier/inspec.rb
Outdated
| @@ -88,6 +88,8 @@ def call(state) | |||
| v2_loader = ::Inspec::Plugin::V2::Loader.new | |||
| v2_loader.load_all | |||
| v2_loader.exit_on_load_error | |||
|
|
|||
| ::Inspec::InputRegistry.instance.cache_inputs = !!config[:cache_inputs] if config[:cache_inputs] | |||
There was a problem hiding this comment.
I'm concerned about tightly coupling the versions of kitchen-inspec and the inspec-core gem. Right now the only constraint in the gemspec is to make sure inspec has plugin support, so it is a broad range of versions that can be compatible. If we tighten the constraint to be the latest release - presumably a release after inspec/inspec#5211 merges - then people can only use kitchen-inspec with the very latest InSpec.
Could we put a guard clause around this that detects if Inspec::InputRegistry.instance responds to cache_inputs=? That would make it more loosely coupled.
There was a problem hiding this comment.
Just pushed with a guard, is that what you had in mind?
Signed-off-by: Thomas Heinen <theinen@tecracer.de>
clintoncwolfe
added
Expeditor: Bump Version Minor
Schwad
approved these changes
Sep 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This allows deactivating the input caching in InSpec to avoid values from previous suites to persist into follow-up runs.
For a detailed explanation see InSpec PR #5211.
Issues Resolved
See InSpec PR #5211.
Check List