work well with other testing frameworks in test-kitchen #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fixes #11 |
|
We should add detection if the path contains directories like |
chris-rock
force-pushed
the
chris-rock/legacy-tk-path
branch
from
f26da1a
to
9bca19a
Compare
chris-rock
force-pushed
the
chris-rock/legacy-tk-path
branch
from
9bca19a
to
8038cce
Compare
chris-rock
changed the title
chris-rock
force-pushed
the
chris-rock/legacy-tk-path
branch
from
8038cce
to
15a3db7
Compare
chris-rock
force-pushed
the
chris-rock/legacy-tk-path
branch
from
981922e
to
05fa066
Compare
| @@ -132,7 +150,6 @@ def runner_options_for_ssh(config_data) | |||
| } | |||
| opts['key_files'] = kitchen[:keys] unless kitchen[:keys].nil? | |||
| opts['password'] = kitchen[:password] unless kitchen[:password].nil? | |||
|
|
|||
| opts | |||
There was a problem hiding this comment.
If you want to save space here, why not also drop the opts? It's the return value of the assignment anyways. And we might as well drop that assignment and just return the hash. ;)
srenatus
added a commit
that referenced
this pull request
Feb 8, 2016
work well with other testing frameworks in test-kitchen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.