Fixed review comments

Signed-off-by: Vasu1105 <vasundhara.jagdale@msystechnologies.com>
inspec · Oct 17, 2017 · 357b401 · 357b401
1 parent 6b8c2ef
commit 357b401
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 208 deletions.
diff --git a/lib/train/file.rb b/lib/train/file.rb
@@ -79,14 +79,16 @@ def source_path
       @path
     end
 
-    # TODO: This methods needs to raise error if not implemented currently it set to nil since conversion
-    # to json currently breaks if raise error for non implementation of these mehtods by every backend file
+    # product_version is primarily used by Windows operating systems only and will be overwritten
+    # in Windows-related classes. Since this field is returned for all file objects, the acceptable
+    # default value is nil
     def product_version
       nil
     end
 
-    # TODO: This methods needs to raise error if not implemented currently it set to nil since conversion
-    # to json currently breaks if raise error for non implementation of these mehtods by every backend file
+    # file_version is primarily used by Windows operating systems only and will be overwritten
+    # in Windows-related classes. Since this field is returned for all file objects, the acceptable
+    # default value is nil
     def file_version
       nil
     end

diff --git a/lib/train/file/local/unix.rb b/lib/train/file/local/unix.rb
@@ -12,7 +12,7 @@ def sanitize_filename(path)
         end
 
         def stat
-          return @stat if defined? @stat
+          return @stat if defined?(@stat)
 
           begin
             file_stat =

diff --git a/lib/train/file/local/windows.rb b/lib/train/file/local/windows.rb
@@ -30,7 +30,7 @@ def owner
         end
 
         def stat
-          return @stat if defined? @stat
+          return @stat if defined?(@stat)
 
           begin
             file_stat =

diff --git a/test/unit/transports/local_file_test.rb b/test/unit/transports/local_file_test.rb