winrm: hide password #171
winrm: hide password #171
Conversation
crepetl
commented
Mar 22, 2017
crepetl
commented
- simply reported what already exists in ssh_connection
There was a problem hiding this comment.
Thank you @crepetl for this improvement. Once the rubocop exception is added, LGTM
| @@ -183,7 +183,9 @@ def session(retry_options = {}) | |||
| # | |||
There was a problem hiding this comment.
@crepetl Could you please add # rubocop:disable Metrics/ClassLength to line 30 https://github.com/chef/train/pull/171/files#diff-f2edeefbb087259b847aa6f5ded7d0f4L30 similar to https://github.com/chef/train/blob/master/lib/train/transports/ssh_connection.rb#L32 This would make rubocop happy.
* simply reported what already exists in ssh_connection Signed-off-by: Laurent CREPET <l.crepet@criteo.com>
There was a problem hiding this comment.
Thank you for your contribution, @crepetl! I'm attempting to rerun the last two travis jobs in an attempt to get this to go green. The failures do not appear to be anything related with your change.
I'll merge once the tests pass.
|
Tests are green! Merging now. Thanks again @crepetl! |
|
You're welcome. |
