Build a complete mock OS object #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InSpec expects there to be four parameters on every OS object:
name, release, family, and arch. When the mock backend is used,
only "family" is ever populated. When evaluating blocks, such
as an only_if block, when the mock backend is used, errors will be
encountered if someone tries to do something like:
os.name.include?('something')
... because `os.name` will be nil during an inspec check, for example.
This change properly populates all four expected parameters of the OS
whenever the mock backend is used. The `mock_os` method still allows
for one-off setting of the value as needed for unit tests, but it's
now merged with the default four values.
Signed-off-by: Adam Leff <adam@leff.co>
chris-rock
approved these changes
Nov 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InSpec expects there to be four parameters on every OS object: name, release, family, and arch. When the mock backend is used, only "family" is ever populated. When evaluating blocks, such as an only_if block, when the mock backend is used, errors will be encountered if someone tries to do something like:
os.name.include?('something')
... because
os.namewill be nil during an inspec check, for example.This change properly populates all four expected parameters of the OS whenever the mock backend is used. The
mock_osmethod still allows for one-off setting of the value as needed for unit tests, but it's now merged with the default four values.Related to inspec/inspec#2250