catch detect failing to parse json #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamleff
approved these changes
Jan 30, 2018
| @platform[:release] = eos_ver['version'] | ||
| @platform[:arch] = eos_ver['architecture'] | ||
| true | ||
| rescue JSON::ParserError => _ |
There was a problem hiding this comment.
Don't even need the assignment here, can just be rescue JSON::ParserError.
| @platform[:release] = eos_ver['version'] | ||
| @platform[:arch] = eos_ver['architecture'] | ||
| true | ||
| rescue JSON::ParserError => _ |
There was a problem hiding this comment.
Don't even need the assignment here, can just be rescue JSON::ParserError.
There was a problem hiding this comment.
force of habit 😁
removed it and updated the PR
This may happen if the exit code is incorrect or the results get scrambled Signed-off-by: Dominik Richter <dominik.richter@gmail.com>
arlimus
force-pushed
the
dom/json-detect
branch
from
736c9b2 to
fb94b5d
Compare
Signed-off-by: Dominik Richter <dominik.richter@gmail.com>
arlimus
force-pushed
the
dom/json-detect
branch
from
fb94b5d to
3e9e212
Compare
jerryaldrichiii
pushed a commit
that referenced
this pull request
Feb 5, 2018
* catch detect failing to parse json This may happen if the exit code is incorrect or the results get scrambled Signed-off-by: Dominik Richter <dominik.richter@gmail.com> * remove variable assignment Signed-off-by: Dominik Richter <dominik.richter@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may happen if the exit code is incorrect or the results get scrambled
Signed-off-by: Dominik Richter dominik.richter@gmail.com