Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable expeditor release tasks #294

Merged
merged 1 commit into from
May 1, 2018
Merged

Enable expeditor release tasks #294

merged 1 commit into from
May 1, 2018

Conversation

jquick
Copy link
Contributor

@jquick jquick commented May 1, 2018

Enable expeditor release scripts. This will allow both train and train-core to be released simultaneously.

This PR will require #293 to be merged before invoking a stable release.

Signed-off-by: Jared Quick jquick@chef.io

@jquick jquick requested a review from a team May 1, 2018 16:57
Copy link
Contributor

@tduffield tduffield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add a VERSION with the initial value + patch bump in it.

CHANGELOG.md Outdated
\* *This Change Log was automatically generated by [github_changelog_generator](https://github.com/skywinder/Github-Changelog-Generator)*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to delete this now.

@jquick jquick force-pushed the jq/enable_expeditor branch from 4840434 to 853dc00 Compare May 1, 2018 17:03
Signed-off-by: Jared Quick <jquick@chef.io>
@jquick jquick force-pushed the jq/enable_expeditor branch from 853dc00 to 8904f94 Compare May 1, 2018 17:03
Copy link
Contributor

@clintoncwolfe clintoncwolfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - my only feedback is that I don't think we are using the github labels mentioned. We can add them, obviously.

@jquick jquick merged commit 02c8696 into master May 1, 2018
@jquick jquick deleted the jq/enable_expeditor branch May 1, 2018 17:42
@clintoncwolfe
Copy link
Contributor

I added the github labels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants