Allow nil password and www_form_encoded_password to work together. #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a URL does not contain a password but options contains www_form_encoded_password: true, an exception was raised because we can't decode a nil value. Signed-off-by: Marc A. Paradise <marc.paradise@gmail.com>
|
np - sorry for the bug :D |
clintoncwolfe
added
Type: Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corrects a bug previously untested path in the change to support www-form-encoded password .
When a URL does not contain a password but options contains
www_form_encoded_password: true, an exception was raised
because we can't decode a nil value.
Signed-off-by: Marc A. Paradise marc.paradise@gmail.com