Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify WindowsPipeRunner stderr to use String #320

Merged
merged 1 commit into from
Jul 5, 2018
Merged

Modify WindowsPipeRunner stderr to use String #320

merged 1 commit into from
Jul 5, 2018

Conversation

jerryaldrichiii
Copy link
Contributor

This modifies WindowPipeRunner to use a String for stderr instead of an object.

2018-07-02-214715_635x633_scrot
2018-07-02-214822_636x633_scrot

@jerryaldrichiii
Modify WindowsPipeRunner stderr to use String
15ec743 
Signed-off-by: Jerry Aldrich <jerryaldrichiii@gmail.com>
jquick
jquick approved these changes Jul 5, 2018
View reviewed changes
Copy link
Contributor

@jquick jquick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jerryaldrichiii

@jquick jquick merged commit 8817a2c into master Jul 5, 2018
@jquick jquick deleted the ja/fix-pipe-runner branch July 5, 2018 12:34
@jerryaldrichiii jerryaldrichiii mentioned this pull request Jul 13, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jquick jquick jquick approved these changes

@miah miah miah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jerryaldrichiii @miah @jquick