Fixes failing test when you have a cred file #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 23, 2018 09:50
This test could fail in cases where you already have a credentails file in the default path (~/.azure/credentials). I am moving the default behavior to `azure.rb` so `file_credentials` can operate on what you pass in. This makes an easier contract as the caller must provide a file, and the test easier since there's no defaulting behavior. Signed-off-by: David McCown <dmccown@chef.io>
Signed-off-by: David McCown <dmccown@chef.io>
ghost
approved these changes
Aug 23, 2018
jquick
approved these changes
Aug 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test could fail in cases where you already have a credentails file
in the default path (~/.azure/credentials).
I am moving the default
behavior to
azure.rbsofile_credentialscan operate on what youpass in. This makes an easier contract as the caller must provide a file,
and the test easier since there's no defaulting behavior.
Signed-off-by: David McCown dmccown@chef.io