Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rescues SystemCallError instead of Errno #346

Merged
merged 1 commit into from
Aug 30, 2018
Merged

Conversation

dmccown
Copy link
Contributor

@dmccown dmccown commented Aug 29, 2018

Fixes #344

This fixes issue #344 by replacing rescue Errno::* with
SystemCallError. Each error in the Errno::Constants is a subclass of
SystemCallError. We can use SystemCallError to handle the exceptions on
different OSes.

Signed-off-by: David McCown dmccown@chef.io

Fixes #344

This fixes issue #344 by replacing rescue `Errno::*` with
`SystemCallError`. Each error in the `Errno::Constants` is a subclass of
SystemCallError. We can use SystemCallError to handle the exceptions on
different OSes.

Signed-off-by: David McCown <dmccown@chef.io>
@dmccown dmccown requested a review from jquick August 29, 2018 22:13
Copy link
Contributor

@jquick jquick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dmccown

@jquick jquick merged commit 760f099 into master Aug 30, 2018
@jquick jquick deleted the dmccown/rescue-msi-port branch August 30, 2018 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unable to use -t azure:// from within docker container.
2 participants