Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Google API application info #378

Merged
merged 1 commit into from
Nov 9, 2018
Merged

Conversation

nathenharvey
Copy link
Contributor

This will help measure requests to the Google API that come from train.

Signed-off-by: Nathen Harvey nathenharvey@google.com

@nathenharvey
Copy link
Contributor Author

The current behavior is that requests are made with an unknown user-agent.

unknown-agent

The new behavior is that the requests include chef-train as the user-agent and the current version of train.

after-the-patch

Copy link
Contributor

@chris-rock chris-rock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition @nathenharvey

lib/train/transports/gcp.rb Outdated Show resolved Hide resolved
* Set the `application_name` to `chef-inspec-train`
* Set the `applicaiton_version` to the current version of train (`Train::VERSION`)

Based on conversation with @chris-rock this is a more descriptive name for this applicaiton.

Signed-off-by: Nathen Harvey <nathenharvey@google.com>
@nathenharvey
Copy link
Contributor Author

squashed the commits so it's a single commit merge when you're ready @chris-rock

Copy link
Contributor

@jquick jquick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nathenharvey

@jquick jquick merged commit 164ae19 into inspec:master Nov 9, 2018
@nathenharvey nathenharvey deleted the gcp-useragent branch November 9, 2018 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants