Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only ship the runtime files in the gem to slim install sizes #388

Merged
merged 1 commit into from
Dec 19, 2018

Conversation

tas50
Copy link
Contributor

@tas50 tas50 commented Dec 10, 2018

Don't ship the readme, changelog, or test files in the gem artifact.
There's no need for these files deep in a Ruby install. This shrinks the
gem install from 108k to 49k.

Signed-off-by: Tim Smith tsmith@chef.io

Don't ship the readme, changelog, or test files in the gem artifact.
There's no need for these files deep in a Ruby install. This shrinks the
gem install from 108k to 49k.

Signed-off-by: Tim Smith <tsmith@chef.io>
Copy link
Contributor

@jerryaldrichiii jerryaldrichiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tas50! Little changes like this really add up.

Copy link
Contributor

@miah miah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tas50 !!

@clintoncwolfe clintoncwolfe merged commit 2f3ed72 into master Dec 19, 2018
@clintoncwolfe clintoncwolfe added Type: Enhancement Improves an existing feature and removed Type: Enhancement labels Mar 19, 2019
@zenspider zenspider deleted the slim branch February 1, 2020 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Improves an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants