Prepare train for using credential sets #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clintoncwolfe
force-pushed
the
cw/cred-set-support
branch
2 times, most recently
from
b69ccf5 to
ae7b78b
Compare
This was referenced Jan 8, 2019
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
clintoncwolfe
force-pushed
the
cw/cred-set-support
branch
from
63edebe to
ca23b1e
Compare
tas50
reviewed
Jan 28, 2019
tas50
reviewed
Jan 28, 2019
clintoncwolfe
commented
Jan 28, 2019
| @@ -228,7 +229,7 @@ | |||
| end | |||
|
|
|||
| it 'returns the local backend if nothing was provided' do | |||
| Train.validate_backend({}).must_equal :local | |||
| Train.validate_backend({}).must_equal 'local' | |||
There was a problem hiding this comment.
If all backend driver names are strings, how did this ever pass as symbols?
marcparadise
approved these changes
Jan 28, 2019
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
jerryaldrichiii
approved these changes
Jan 31, 2019
| @@ -3,5 +3,6 @@ | |||
| require 'minitest/autorun' | |||
| require 'minitest/spec' | |||
| require 'mocha/setup' | |||
| require 'byebug' | |||
There was a problem hiding this comment.
Hey! It's in the helper now 😄
This was referenced Feb 1, 2019
clintoncwolfe
added
Aspect/Integration
Type: Enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Train has historically either used explicit options passed in a hash, or parsed a --target option as a URL. Both are a bit unwieldy, especially the URI method.
This PR makes a few changes to make it easier to work with credentials passed in as a hash.